Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codespell from 2.3.0 to 2.4.0 in /.github/workflows/requirements #575

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 27, 2025

Bumps codespell from 2.3.0 to 2.4.0.

Release notes

Sourced from codespell's releases.

v2.4.0

What's Changed

... (truncated)

Commits
  • db0100e Run pytest GitHub Action on an ARM processor (#3619)
  • c6bdc1f [pre-commit.ci] autoupdate less frequently
  • 654b3ed Run ruff format
  • 913871e Apply ruff/flake8-pytest-style rule PT006
  • b782f25 Changes for ruff 0.9.1
  • 9c3a652 [pre-commit.ci] pre-commit autoupdate
  • 2626491 Remove socioeconomic entries
  • ec57cff Add spelling correction for denila and variant.
  • 2acfc37 [pre-commit.ci] pre-commit autoupdate
  • 51262cf [pre-commit.ci] pre-commit autoupdate
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [codespell](https://github.com/codespell-project/codespell) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/codespell-project/codespell/releases)
- [Commits](codespell-project/codespell@v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: codespell
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 27, 2025
@github-actions github-actions bot added the ci CI, unit tests, GitHub actions label Jan 27, 2025
@pearce8
Copy link
Collaborator

pearce8 commented Jan 28, 2025

This version fails at spellcheck. Since we need to keep the spelling as is and not fail going forward, I am not sure we can merge this @ilumsden any suggestions?

Run black --diff --check .
All done! ✨ 🍰 ✨
60 files would be left unchanged.
./taxonomy.yaml:25: hep ==> heap, help

@ilumsden
Copy link
Collaborator

@pearce8 do you want taxonomy.yaml to have the spell checker applied to it? If not, it would be pretty easy to have to skipped in CI. In general, it would probably be good to define a set of files that you don't want spell checking applied to, and then we can create a .codespellrc file to tell codespell not to check those files.

@ilumsden
Copy link
Collaborator

Additionally, if there are certain words that you don't want codespell to check, it should be possible to encode that in .codespellrc too.

@ilumsden
Copy link
Collaborator

Oh, wait. Nevermind. There's already a configuration in pyproject.toml, so everything I suggested should go there instead of .codespellrc

@pearce8
Copy link
Collaborator

pearce8 commented Jan 28, 2025

I guess we will need to exclude the taxonomy from spell checking then since it has acronyms which are lower case.... @ilumsden Can you please add the code to exclude it to this PR?

@ilumsden
Copy link
Collaborator

Sure. I'm going to finish some stuff for Codecov quickly, and then I'll tackle this.

@pearce8 pearce8 merged commit 86a34ea into develop Jan 28, 2025
9 checks passed
@pearce8 pearce8 deleted the dependabot/pip/dot-github/workflows/requirements/codespell-2.4.0 branch January 28, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI, unit tests, GitHub actions dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants