Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

venado system specs #548

Merged
merged 23 commits into from
Jan 23, 2025
Merged

venado system specs #548

merged 23 commits into from
Jan 23, 2025

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Jan 15, 2025

Description

This PR adds the system config specs for the LANL Venado system.

  1. saxpy errors out since CUDA 12.5 does not support clang 18 as the host compiler. Adding "-allow-unsupported-compiler" does not work (or the flag isn't begin added correctly by spack)
  2. caliper fails when apply a patch for the aarch64 architecture in spack

Dependencies: FIXME:Add a list of any dependencies.

Fixes issue(s): FIXME:Add list of relevant issues.

Type of Change

  • {x} Adding a system, benchmark, or experiment
  • { } Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • {X} Create a new directory for the system and a new system.py file
  • { X} Add a new dry run unit test in .github/workflows
  • {X} System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • { } Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@pearce8
Copy link
Collaborator

pearce8 commented Jan 15, 2025

@rfhaque where is the PR checklist template? Those are helpful for reviewing. In particular, for adding a new system, we also need:
{ } Add a human-readable system description to systems/all_system_definitions
{ } Verify info added in all_system_definitions generates a new system column in Catalogue/System Specifications (https://software.llnl.gov/benchpark/system-list.html)
{ } Add a dry run of an existing benchmark using the new system definition

(@slabasan, if those are not listed in the PR template right now, we probably want to add them)

@pearce8 pearce8 requested a review from slabasan January 15, 2025 20:49
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfhaque What is different about this spack package from upstream? We need to work with @dbo to review/upstream it.

return {
"cuda_arch": "90",
"default_cuda_version": self.spec.variants["cuda"][0],
"extra_batch_opts": '"-A llnl_ai_g -pgpu"',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfhaque what does this extra_batch_opts do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pearce8 The extra_batch_opts requests the required partition and account. We may need to parameterize this

@github-actions github-actions bot added the ci CI, unit tests, GitHub actions label Jan 23, 2025
@rfhaque rfhaque marked this pull request as ready for review January 23, 2025 04:43
@pearce8 pearce8 merged commit 2a9d9fc into develop Jan 23, 2025
8 checks passed
@pearce8 pearce8 deleted the systems/venado branch January 23, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI, unit tests, GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants