-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
venado system specs #548
venado system specs #548
Conversation
@rfhaque where is the PR checklist template? Those are helpful for reviewing. In particular, for adding a new system, we also need: (@slabasan, if those are not listed in the PR template right now, we probably want to add them) |
repo/caliper/sampler-service-missing-libunwind-include-dir.patch
Outdated
Show resolved
Hide resolved
repo/caliper/package.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return { | ||
"cuda_arch": "90", | ||
"default_cuda_version": self.spec.variants["cuda"][0], | ||
"extra_batch_opts": '"-A llnl_ai_g -pgpu"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rfhaque what does this extra_batch_opts do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pearce8 The extra_batch_opts requests the required partition and account. We may need to parameterize this
Description
This PR adds the system config specs for the LANL Venado system.
Dependencies: FIXME:Add a list of any dependencies.
Fixes issue(s): FIXME:Add list of relevant issues.
Type of Change
Checklist:
If adding/modifying a system:
system.py
file.github/workflows
If adding/modifying a benchpark:
application.py
and (maybe)package.py
under a new directoryfor this benchmark
section
If adding/modifying a experiment:
experiment.py
under existing directory for specific benchmarkIf adding/modifying core functionality:
.github/workflows
and.gitlab/ci
unit tests (if needed)