Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

El Capitan system: always include GCC compiler #515

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

scheibelp
Copy link
Collaborator

And add preference for %cce when setting compiler=cce

Some low level dependencies won't build with %cce, so this adds a GCC compiler definition regardless of what the user requests. To avoid using GCC in other cases, this adds a preference for %cce.

The changes here do not guarantee using %cce: doing so would likely require tighter coupling between the system and experiment class (which is in the works).

…add preference for cce when setting compiler=cce
@rfhaque
Copy link
Collaborator

rfhaque commented Jan 2, 2025

@scheibelp Is is possible to add versions for cce (e.g. [email protected], [email protected] etc), cray-mpich and other dependencies in llnl-elcapitan/system.py

@scheibelp
Copy link
Collaborator Author

Is is possible to add versions for cce (e.g. [email protected], [email protected] etc), cray-mpich and other dependencies in

Yes, in some sense handling this is a separate concern, and I could do so if you like (preferably in another PR).

In more detail: as a direct change, you take the current code in llnl-elcapitan/system.py

        if compiler == "cce":
            compiler_cfg_path = self.next_adhoc_cfg()
            with open(compiler_cfg_path, "w") as f:
                f.write(self.rocm_cce_compiler_cfg(rocm, "16.0.0"))

and change "16.0.0" to "18.0.0". To support both, I think it would make sense to add a conditional variant like

    variant(cce_version, values=("16", "18"), when="compiler=cce")

And then similarly, you would only need to change the one line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants