Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding libraries to dynamic genericx86, and variants to other systems #467

Merged
merged 23 commits into from
Jan 21, 2025

Conversation

pearce8
Copy link
Collaborator

@pearce8 pearce8 commented Dec 2, 2024

Description: Fixes #454.

@rfhaque please see/fix the error in CI dry run.

Dependencies: None.

Type of Change

  • { } Adding a system, benchmark, or experiment
  • {X} Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • {X} Add a new dry run unit test in .github/workflows
  • {X} System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • { } Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@github-actions github-actions bot added the ci CI, unit tests, GitHub actions label Dec 2, 2024
@rfhaque
Copy link
Collaborator

rfhaque commented Dec 13, 2024

Closes #454.

@rfhaque please see/fix the error in CI dry run.

@pearce8 Done. The checks are now working

@slabasan slabasan marked this pull request as ready for review December 18, 2024 17:39
@github-actions github-actions bot added the experiment New or modified experiment label Jan 20, 2025
@pearce8 pearce8 changed the title Replacing dynamic saxpy with dynamic amg on genericx86 Adding libraries to dynamic genericx86, and variants to other systems Jan 21, 2025
@pearce8 pearce8 merged commit cd82828 into develop Jan 21, 2025
10 of 12 checks passed
@pearce8 pearce8 deleted the test/amg-genericx86 branch January 21, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI, unit tests, GitHub actions experiment New or modified experiment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make genericx86 dynamic system equivalent to legacy
3 participants