Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/new modifier implementation #356

Merged
merged 40 commits into from
Oct 24, 2024
Merged

Feature/new modifier implementation #356

merged 40 commits into from
Oct 24, 2024

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Aug 27, 2024

New modifier implementation using experiment.py

alecbcs and others added 19 commits August 21, 2024 17:14
@alecbcs
Add initial framework for experiment init
f5d42ea
@becker33
saxpy: fix mismatch between variable name and usage
eaf72d0
@becker33
cmd/experiment: fix interface to Experiment class
19a9cfd
@becker33
cmd/experiment: implement benchpark experiment list
0823c12
@becker33
cmd/experiment: remove vestigial references to 'system'
d80ecef
@becker33
spec: fix bug with ConcreteSpec.satisfies and ConcreteSpec.intersects
7b9c2e2
@becker33
spec: remove vestigial 'autospec' decorator
7c6f80c
Merge branch 'develop' of github.com:LLNL/benchpark into develop
2238ac1
Add amg2023 experiment.py
7c46969
Fix formatting
0c0bbd3
Changes to spack section
0c46273
Fix formatting
7bff318
Add caliper support
2de749d
Merge remote-tracking branch 'origin/develop' into feature/amg2023-ex…
b0baff3 
…periment
Changes
56b4737
Fixes
fdfce26
Fix formatting
0dc3af8
Fix cali file name
f33103d
Remove redundant caliper modifier implementations
54347d5
@github-actions github-actions bot added experiment New or modified experiment ci CI, unit tests, GitHub actions labels Aug 27, 2024
@rfhaque rfhaque requested a review from becker33 September 20, 2024 20:12
scheibelp
scheibelp reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@scheibelp scheibelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggestion on refactoring caliper.Caliper into two classes to make it easier to assemble modifier/spec components.

@scheibelp scheibelp mentioned this pull request Oct 17, 2024
Closed
4 tasks
@pearce8 pearce8 mentioned this pull request Oct 21, 2024
Merged
@scheibelp scheibelp merged commit 92f65cf into develop Oct 24, 2024
8 checks passed
@pearce8 pearce8 deleted the feature/new-modifier-implementation branch November 21, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scheibelp scheibelp scheibelp approved these changes

@alecbcs alecbcs Awaiting requested review from alecbcs

@pearce8 pearce8 Awaiting requested review from pearce8

@becker33 becker33 Awaiting requested review from becker33

Assignees
No one assigned
Labels
ci CI, unit tests, GitHub actions experiment New or modified experiment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rfhaque @scheibelp @alecbcs @becker33 @pearce8