Add transfer function #828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @MrBurmark |
MrBurmark
reviewed
May 31, 2023
| { | ||
| auto alloc_record = findAllocationRecord(ptr); | ||
|
|
||
| if (!(alloc_record->strategy->treatAsPassthrough() && to.getAllocationStrategy()->treatAsPassthrough())) { |
There was a problem hiding this comment.
So this does a direct transfer when the underlying allocators are the same, but moves when they are different? Wouldn't this allow a direct transfer between named allocators built on different base allocators? Should this take a resource to use for the copy?
MrBurmark
reviewed
May 31, 2023
There was a problem hiding this comment.
This looks reasonable as a start.
I have a couple of questions about certain cases. I don't remember all of the constraints on this so the implementation can remain simple.
Should there be a special case for transferring to and from the same allocator?
What about transferring from a named allocator to the underlying allocator and vice-versa?
Does this mess up the stats/counters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.