Skip to content

FEM-based Linear Sweep #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Apr 8, 2025
Merged

FEM-based Linear Sweep #503

merged 44 commits into from
Apr 8, 2025

Conversation

rchen20
Copy link
Member

@rchen20 rchen20 commented Feb 19, 2025

Summary

  • This PR is a feature
  • It does the following:
    • Adds a FEM-based linear sweep algorithm at the request of the DT team.
  • Some caveats:
    • There is only one problem size available due to the need for a mesh generator. As a result, the mesh parameters are contained in FEMSWEEP_DATA.hpp. The transport team will work on duplicating mesh generation logic in the near future.
    • Some problem parameters are a function of the mesh generation, which results in magic numbers at the moment.

@rchen20 rchen20 changed the title DRAFT: Initial FEM based linear sweep port. DRAFT: FEM-based Linear Sweep Feb 19, 2025
@rchen20 rchen20 changed the title DRAFT: FEM-based Linear Sweep FEM-based Linear Sweep Mar 24, 2025
@rchen20 rchen20 requested a review from a team March 24, 2025 23:50
@rchen20
Copy link
Member Author

rchen20 commented Mar 24, 2025

Hello @LLNL/raja-core, this PR is ready to go. Please review when you can!

Copy link
Member

@artv3 artv3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @rchen20 !

Copy link
Member

@artv3 artv3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can add the SYCL variant? We have a few examples in other FEM kernels that should help guide the implementation here.

@rchen20 rchen20 requested a review from artv3 April 7, 2025 20:37
artv3
artv3 previously requested changes Apr 7, 2025
@artv3 artv3 dismissed their stale review April 7, 2025 22:16

Not part of the goals....

@rchen20 rchen20 merged commit 7ee6e5b into develop Apr 8, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants