Reshape method #1760
Reshape method #1760
Conversation
artv3
requested review from
MrBurmark,
adayton1,
rhornung67,
mdavis36,
johnbowen42,
rchen20 and
long58
|
@MrBurmark , @rhornung67 I think the example for the reshape method can be simplified. I just pushed up a new version. I was a bit worried the previous version might have too much going on. |
include/RAJA/util/View.hpp
Outdated
| } | ||
|
|
||
| template<std::size_t...Is> | ||
| struct Reshape<std::index_sequence<Is...>> |
There was a problem hiding this comment.
@MrBurmark , this is the specialization that takes an index_sequence and identifies the correct unit stride
There was a problem hiding this comment.
Makes sense, I see an example is documentation coming?
There was a problem hiding this comment.
Yes, thanks for reminding me. I'll make something in the read the docs page within the next few days.
| // Initialize memory using right most unit stride | ||
| // | ||
| //----------------------------------------------------------------------------// | ||
| std::cout << "\n\nInitialize array with right most indexing...\n"; |
There was a problem hiding this comment.
I think these implementations are much easier to understand if your intent is just to show the mechanics of View reshaping. 👍
|
I fixed a bug with the custom sequence, thanks @rhornung67 for point it out. This PR is now ready for review. |
Co-authored-by: Jason Burmark <[email protected]>
Summary
This PR adds helper methods to views to create Reshape methods with compile time options C and Fortran style indexing