add combiner for all #779
Merged
add combiner for all #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelodder7
requested review from
FedericoAmura and
Ansonhkg
and removed request for
Ansonhkg
Ansonhkg
changed the base branch from
feature/lit-3748-naga
to
feat/naga-fix-bls-wasm-cleanup
Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
mikelodder7
force-pushed
the
ml/combine_all_signatures
branch
from
1a7d312 to
4ab5e93
Compare
Signed-off-by: Michael Lodder <[email protected]>
Ansonhkg
changed the base branch from
feat/naga-fix-bls-wasm-cleanup
to
feat/rc-naga-2025-01-30b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a single combine_and_verify method for all signature types returned from lit-node.
Type of change
How Has This Been Tested?
Works for the same tests in lit-node.
The WASM after building is 1.5MB with these new changes. Before it was 670KB. We might be able to remove the ECDSA portion entirely but I left it in for now.