Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated README files #721

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

phoenixx11
Copy link

@phoenixx11 phoenixx11 commented Nov 17, 2024

-removed references to Vanilla Js as it was not being used -verified all functionalities described in README files are working -added missing details and clarified existing info in the README files

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

u

  • updated the read me files with the changes

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

-removed references to Vanilla Js as it was not being used
-verified all functionalities described in README files are working
-added missing details and clarified existing info in the README files
@CLAassistant
Copy link

CLAassistant commented Nov 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also make sure the root readme.md is tested and updated @phoenixx11

@phoenixx11
Copy link
Author

phoenixx11 commented Nov 19, 2024 via email

@phoenixx11
Copy link
Author

Tested!Done

@Ansonhkg
Copy link
Collaborator

Ansonhkg commented Dec 2, 2024

Tested!Done

Has every single command been checked on the README.md?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants