remove unet bottleneck dim from dataset params used to generate unique dataset hash#28
Merged
michaelmckinsey1 merged 1 commit intoLBANN:mainfrom Apr 2, 2026
Conversation
michaelmckinsey1
requested changes
Mar 19, 2026
Collaborator
michaelmckinsey1
left a comment
michaelmckinsey1
left a comment
There was a problem hiding this comment.
Does this mean that my dataset can now be reused if I only change the bottleneck dim, whereas previously it would generate a new one?
michaelmckinsey1
approved these changes
Apr 2, 2026
Collaborator
Answer is Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameters we hash to create a unique dataset ID should really only be those that actually affect the dataset in some way. We currently include
unet_bottleneck_dimin this set, but it does not impact the dataset at all. This PR removes that param from the hashing.