Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: text shadow support and adveture 4.18.0 bump #224

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Conversation

zml2008
Copy link
Member

@zml2008 zml2008 commented Dec 23, 2024

today in "abby attempts to do web," text shadows

@MiniDigger
Copy link
Member

MiniDigger commented Dec 27, 2024

generally looks good, I just noticed that holograms/text display entities don't have text shadow. in vanilla, only the default one isn't shown.
I think just removing the !important here in style.css should be enough?

#output-pre.mode-hologram span {
    text-shadow: none !important;
}

that way css inheritance can work as expected: the default shadow color is set on the <pre>, that selector disables the default one and the render hook can then set it on the span which will override it as expected.

edit: the same might apply to server list, but I have no good way to test the vanilla behavior rn

@zml2008 zml2008 self-assigned this Jan 1, 2025
@zml2008
Copy link
Member Author

zml2008 commented Jan 1, 2025

seems to work, thanks mini

@zml2008 zml2008 merged commit beb0551 into main Jan 1, 2025
3 checks passed
@zml2008 zml2008 deleted the feat/text-shadow branch January 1, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants