Make sure to set the canonical URL only if the URI string is not empty to avoid /0 as the href value in the profile view
#9837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y to avoid `/0` as the href value in the profile view
|
I don't see in which situation there is a wrong url to the user profile, i have opened the user profile as not logged and logged but the links to the profile in the header are correct |
|
@xillibit, thanks for the merge! To your previous posting: If you check the profile page's source code, you will see the broken canonical URL that was fixed with this PR. Screenshot:
|
xillibit
pushed a commit
that referenced
this pull request
Mar 9, 2025
…ot empty to avoid `/0` as the href value in the profile view (#9837)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR will fix the following error in the profile view:
<link href="/0" rel="canonical">For instance, you can open rich's profile page (https://www.kunena.org/forum/user/2198-rich) and check the source code. You will find the wrongly created canonical URL in the header section. This 404 link is made on each profile page and affects SEO.
Testing Instructions
Check any profile page in the latest release. Apply the patch, and the incorrect tag will no longer be created.