Addition Of Logging System #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burgyn
reviewed
Nov 4, 2024
| var (script, compilation) = _compiler.CompileScript(_script.ProcessedContent); | ||
| _script.ScriptObject = script; | ||
| _script.Compilation = compilation; | ||
|
|
||
| context.Logger.LogTrace("Compilation of the script on path '{ScriptPath}' finished.", _script.Script.File.RelativePath); |
There was a problem hiding this comment.
Nerob to teraz. A niekedy na neskôr by som dal úlohu, že tieto logy by obsahovali aj čas trvania tej akcie.
There was a problem hiding this comment.
Myslím tým aj tie ďalšie ktoré sú typu Start-Stop.
Merged
matejicko
added
the
unresolved comments
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements initial logging system. In
ApplicationContextthere is public instance of Microsoft'sILoggerwhich will be accessible during whole pipeline run in each step. If another classes need to use logger, it's generic implementation can be automatically injected from DI container.More information about logging system within this project here.