Don't resolve built-in types against the index if index is updating

Fixes #3168
KronicDeth · May 26, 2023 · 5bd799a · 5bd799a
1 parent 66cb85e
commit 5bd799a
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -292,6 +292,8 @@
     The API is scheduled for removal and is replaced by `Call.align(AlignX.FILL)`.
 * [#3214](https://github.com/KronicDeth/intellij-elixir/pull/3214) - [@KronicDeth](https://github.com/KronicDeth)
   * Ignore `group:` for docs.
+* [#3242](https://github.com/KronicDeth/intellij-elixir/pull/3242) - [@KronicDeth](https://github.com/KronicDeth)
+  * Don't resolve built-in types against the index if index is updating.
 
 ## v15.0.1
 

diff --git a/resources/META-INF/changelog.html b/resources/META-INF/changelog.html
@@ -25,6 +25,7 @@ <h1>v15.0.1</h1>
           <code>175</code> in IntelliJ 2023.1's builder number, <code>231.8109.175</code>.
         </p>
       </li>
+      <li>Don't resolve built-in types against the index if index is updating.</li>
     </ul>
   </li>
 </ul>

diff --git a/src/org/elixir_lang/reference/resolver/Type.kt b/src/org/elixir_lang/reference/resolver/Type.kt
@@ -1,5 +1,6 @@
 package org.elixir_lang.reference.resolver
 
+import com.intellij.openapi.project.DumbService
 import com.intellij.psi.PsiElement
 import com.intellij.psi.ResolveResult
 import com.intellij.psi.impl.source.resolve.ResolveCache
@@ -56,16 +57,18 @@ object Type : ResolveCache.PolyVariantResolver<org.elixir_lang.reference.Type> {
         val project = entrance.project
         val resolveResultList = mutableListOf<ResolveResult>()
 
-        StubIndex.getInstance().processElements(
-            ModularName.KEY,
-            ":erlang",
-            project,
-            GlobalSearchScope.allScope(project),
-            NamedElement::class.java
-        ) { namedElement ->
-            resolveResultList.addAll(MultiResolve.resolveResults(name, arity, false, namedElement))
+        if (!DumbService.isDumb(project)) {
+            StubIndex.getInstance().processElements(
+                ModularName.KEY,
+                ":erlang",
+                project,
+                GlobalSearchScope.allScope(project),
+                NamedElement::class.java
+            ) { namedElement ->
+                resolveResultList.addAll(MultiResolve.resolveResults(name, arity, false, namedElement))
 
-            true
+                true
+            }
         }
 
         return resolveResultList.toTypedArray()