Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the Jacobian at point of quad_3d_9 #7406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vryy
Copy link
Contributor

@vryy vryy commented Sep 2, 2020

Description
One Jacobian function of quad 9 (3d) is wrong

Please mark the PR with appropriate tags:

  • Api Breaker

Changelog
Fix the Jacobian function at a point. This is important for boundary conditions on hex mesh.

@vryy vryy requested a review from a team as a code owner September 2, 2020 12:15
Copy link
Member

@RiccardoRossi RiccardoRossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me. could u add a test?

@RiccardoRossi
Copy link
Member

also i would check if the same problem also exist in the quad_3d_8 and quad_32_4

@loumalouomega
Copy link
Member

strange, we had tests, but maybe because the tests for 3D geometries were the same as 2D geometries we did not notice. @RiccardoRossi I am quite sure Quad3D4N is OK, I use it a lot

@loumalouomega
Copy link
Member

also i would check if the same problem also exist in the quad_3d_8 and quad_32_4

I have checked and these two are OK

@RiccardoRossi
Copy link
Member

@loumalouomega apparently if we just flip the normal for Quad3d4 the determinant is not computed correctly. @philbucher could u comment briefly? i think you bug may be connected to this one

@philbucher
Copy link
Member

@RiccardoRossi and I were briefly discussing this morning and it might be that the computation of the det of the Jacobian is also not correct in Q3D4N IIRC

there is an issue about the flipped normals => #7358

@loumalouomega
Copy link
Member

@RiccardoRossi and I were briefly discussing this morning and it might be that the computation of the det of the Jacobian is also not correct in Q3D4N IIRC

there is an issue about the flipped normals => #7358

What is wrong?, there are tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants