-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the Jacobian at point of quad_3d_9 #7406
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me. could u add a test?
also i would check if the same problem also exist in the quad_3d_8 and quad_32_4 |
strange, we had tests, but maybe because the tests for 3D geometries were the same as 2D geometries we did not notice. @RiccardoRossi I am quite sure Quad3D4N is OK, I use it a lot |
I have checked and these two are OK |
@loumalouomega apparently if we just flip the normal for Quad3d4 the determinant is not computed correctly. @philbucher could u comment briefly? i think you bug may be connected to this one |
@RiccardoRossi and I were briefly discussing this morning and it might be that the computation of the det of the Jacobian is also not correct in Q3D4N IIRC there is an issue about the flipped normals => #7358 |
What is wrong?, there are tests |
Description
One Jacobian function of quad 9 (3d) is wrong
Please mark the PR with appropriate tags:
Changelog
Fix the Jacobian function at a point. This is important for boundary conditions on hex mesh.