-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][AnalysisStage][DO NOT MERGE] InitializeSolutionStep() change in the order #6567
base: master
Are you sure you want to change the base?
[Core][AnalysisStage][DO NOT MERGE] InitializeSolutionStep() change in the order #6567
Conversation
Small but profound change. The idea is that InitializeSolutionStep of the solver should be called BEFORE applying BCs and Predicting This makes no difference for most elements, but may be important for UpdatedLagrangian or Corotational elements This branch is to discuss this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking to avoid accidental merge
tests in ContactApp segfault |
Probably I need to refactor the Contact NR |
I suspect that this is not specific of this PR. tests are also giving an error in #6494 which seems to be unrelated to that PR |
Those are different tests |
Those tests are in the CI and run all the time |
@KratosMultiphysics/dem just to be aware of this |
Not directly related, but I think the function "ApplyBoundaryConditions" is misleading as it calls also processes which have nothing to do with BCs and should probably be renamed.. |
I totally agree with @ddiezrod . It seems like |
@RiccardoRossi many tests fail, not just the ones related with UL element, for example the ones related with displacement control |
I checked the CoSim tests with this and they worked |
Small but profound change.
The idea is that InitializeSolutionStep of the solver should be called BEFORE applying BCs and Predicting
This makes no difference for most elements, but may be important for UpdatedLagrangian or Corotational elements
This branch is to discuss this.