Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][AnalysisStage][DO NOT MERGE] InitializeSolutionStep() change in the order #6567

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RiccardoRossi
Copy link
Member

Small but profound change.

The idea is that InitializeSolutionStep of the solver should be called BEFORE applying BCs and Predicting
This makes no difference for most elements, but may be important for UpdatedLagrangian or Corotational elements

This branch is to discuss this.

Small but profound change.

The idea is that InitializeSolutionStep of the solver should be called BEFORE applying BCs and Predicting
This makes no difference for most elements, but may be important for UpdatedLagrangian or Corotational elements

This branch is to discuss this.
@loumalouomega loumalouomega changed the title Change in the order [Core][DO NOT MERGE]Change in the order Mar 18, 2020
@rubenzorrilla rubenzorrilla changed the title [Core][DO NOT MERGE]Change in the order [Core][AnalysisStage] InitializeSolutionStep() change in the order Mar 18, 2020
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking to avoid accidental merge

@loumalouomega loumalouomega changed the title [Core][AnalysisStage] InitializeSolutionStep() change in the order [Core][AnalysisStage][DO NOT MERGE] InitializeSolutionStep() change in the order Mar 18, 2020
@philbucher
Copy link
Member

tests in ContactApp segfault

@loumalouomega
Copy link
Member

tests in ContactApp segfault

Probably I need to refactor the Contact NR

@RiccardoRossi
Copy link
Member Author

I suspect that this is not specific of this PR.

tests are also giving an error in #6494 which seems to be unrelated to that PR

@loumalouomega
Copy link
Member

I suspect that this is not specific of this PR.

tests are also giving an error in #6494 which seems to be unrelated to that PR

Those are different tests

@philbucher
Copy link
Member

Those tests are in the CI and run all the time
If they fail I am 99% sure it is related to the corresponding PR

@maceligueta
Copy link
Member

@KratosMultiphysics/dem just to be aware of this

@ddiezrod
Copy link
Contributor

Not directly related, but I think the function "ApplyBoundaryConditions" is misleading as it calls also processes which have nothing to do with BCs and should probably be renamed..

@maceligueta
Copy link
Member

I totally agree with @ddiezrod . It seems like ApplyBoundaryConditions is calling
ExecuteInitializeSolutionStep for all processes. These processes might be doing things that are not related to the boundary conditions.

@loumalouomega
Copy link
Member

@RiccardoRossi many tests fail, not just the ones related with UL element, for example the ones related with displacement control

@philbucher
Copy link
Member

I checked the CoSim tests with this and they worked
Still @KratosMultiphysics/cosimulation I suggest you try this also with your real examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants