[Fluid] Symbolic implementation Navier-Slip terms #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can u also add the jpg with the formulation? |
|
jpg? |
|
the scan of the paper where you wrote the formulation... in latex would be better of course, but at least the jpg is something |
|
ping is this still active? |
🤦♂️ my apologies. I would try to add some documentation to this... |
|
is this still active? |
|
ping |
|
@RiccardoRossi as we can ensure that the current implementation is correct I don't think we need to add the symbolic generator for such an specific thing. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an alternative symbolic implementation of the Navier-Slip condition for the discontinuous embedded element. It was quite useful for debugging the "official" one (which was proved to be well implemented), so it might be interesting to keep the source files that generate it.