[Core] Brep Surface - trimmed integration (Part 2 - Inner loop) #13080
+73
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Máté Kelemen <[email protected]>
There was a problem hiding this comment.
Some comments:
- Why not "solution_outer" instead of "solution" for more clarity and consistence?
- Can we propose a better name for the Clipper operation, rather than "d"?
There was a problem hiding this comment.
Just for the sake of consistency, I would propose separating all the composed names with _, for example: best_vertex instead of bestvertex, or min_weight instead of minweight
We change "solution" to "solution_outer" and add a proper naming for the inner and outer Clipper operations
juancamarotti
previously approved these changes
Feb 4, 2025
rickyaristio
dismissed
juancamarotti’s stale review
The merge-base changed after approval.
|
@KratosMultiphysics/technical-committee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is the second part of the PR series to fix the problem related to the trimmed integration in the IGA application.
This PR adds additional operations for the inner loop trimming.
Dependencies: #13072
The test cases will be elaborated on in the next PR.