[CoSim] Extra options for ComputeNormalsOperation #13039
Conversation
| @@ -222,6 +222,14 @@ void AddGeometricalUtilitiesToPython(pybind11::module &m) | |||
| rNormalCalculationUtils.CalculateNormals<ModelPart::ConditionsContainerType,true>(rModelPart, EnforceGenericAlgorithm);}) | |||
| .def("CalculateNormals", [](NormalCalculationUtils& rNormalCalculationUtils, ModelPart& rModelPart){ | |||
| rNormalCalculationUtils.CalculateNormals<ModelPart::ConditionsContainerType,true>(rModelPart);}) | |||
| .def("CalculateElementNormals", [](NormalCalculationUtils& rNormalCalculationUtils, | |||
There was a problem hiding this comment.
The problem is that this is genarating an inconsistency, both Condictions/Elements should be defined even if that means that two methods do exactly the same.
There was a problem hiding this comment.
Disclaimer: this is actually my change.
The problem is that this is genarating an inconsistency, both Condictions/Elements should be defined even if that means that two methods do exactly the same.
I don't quite get it, can you elaborate a bit plz? Currently, there are no functions exposed to python that would compute normals on Elements. They exclusively operate on Conditions. Am I missing something?
There was a problem hiding this comment.
CalculateConditionNormals should be defined al well, even if it is the same as CalculateNormals, for the sake of consistency IMHO
There was a problem hiding this comment.
Ah I see now. Fine by me, but I guess the standard CalculateNormals (computing conditions' normals) should stay as well for backward compatibility, right?
This PR is related to coupling the
CableNetApplicationwith theMPMApplication.Elements instead ofConditions@matekelemen @philbucher