Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FluidDynamicsApplication] Add a new utility to measure the volume of water/air in the cut elements. #13032

Merged
merged 14 commits into from
Jan 25, 2025

Conversation

uxuech
Copy link
Contributor

@uxuech uxuech commented Jan 23, 2025

📝 Description
This PR adds a new utility to measure the volume of water/air in the cut elements.
These two functions are necessary to properly calculate the source term mentioned in the PR #13031.
🆕 Changelog

  • Adding two method to fluid auxiliar utilities
  • Adding each corresponding test

@uxuech uxuech requested a review from a team as a code owner January 23, 2025 18:18
Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minors. Overall, implementation looks good to me.

uxuech and others added 12 commits January 24, 2025 15:13
…_utilities_to_python.cpp

Co-authored-by: Rubén Zorrilla <[email protected]>
…_utilities_to_python.cpp

Co-authored-by: Rubén Zorrilla <[email protected]>
…uxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <[email protected]>
…uxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <[email protected]>
…uxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <[email protected]>
…uxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <[email protected]>
…uxiliary_utilities.h

Co-authored-by: Rubén Zorrilla <[email protected]>
…uxiliary_utilities.cpp

Co-authored-by: Rubén Zorrilla <[email protected]>
…ry_utilities.py

Co-authored-by: Rubén Zorrilla <[email protected]>
…uxiliary_utilities.h

Co-authored-by: Rubén Zorrilla <[email protected]>
…ry_utilities.py

Co-authored-by: Rubén Zorrilla <[email protected]>
…ry_utilities.py

Co-authored-by: Rubén Zorrilla <[email protected]>
rubenzorrilla
rubenzorrilla previously approved these changes Jan 24, 2025
@uxuech uxuech merged commit b54cf46 into master Jan 25, 2025
11 checks passed
@uxuech uxuech deleted the cut_domain_auxiliar_utility branch January 25, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants