Skip to content

Conversation

@pahill
Copy link
Contributor

@pahill pahill commented Sep 1, 2025

No description provided.

@pahill pahill requested a review from zamulla September 1, 2025 15:37
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you missed running the wrapper task for the second time, read here

[versions]
agp = "8.5.2"
kotlin = "2.1.10"
agp = "8.11.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess 8.10.1 for now, see here for more context

@pahill pahill requested a review from avan1235 September 1, 2025 15:50
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.0.0-bin.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.14.3 at most please, see here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avan1235 - so do I just run './gradlew wrapper --gradle-version 8.14.3' twice? Sorry, I usually do this manually 🫨

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's the way to do that 👍🏻

@pahill pahill requested a review from avan1235 September 2, 2025 07:56
Copy link
Contributor

@avan1235 avan1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I don't have rights to approve)

@pahill pahill merged commit 48a94c4 into main Sep 3, 2025
0 of 20 checks passed
@pahill pahill deleted the update_kotlin_deps branch September 3, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants