Closed
Conversation
…ataFrame.convert()
…sing, but can never result in Char and can never fail (since it can parse to String)
36d6acc to
eee84c2
Compare
I remember any chars in the ascii table can be converted into Int automatically in Java. |
Collaborator
Author
yes indeed! However, in java you need to be careful when you want to convert to/from ascii codes or the readable values. In Kotlin, this has been made clearer: // get ascii code from char
'1'.code == 49
// get readable value
'1'.digitToInt() == 1
// and back, from ascii code
49.toChar == '1'
// back to readable char
1.digitToChar() == '1'In DataFrame, I'd like |
Collaborator
Author
|
Surpassed by #1420 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #998
This PR can best be reviewed per-commit. It contains 3 parts where we can enhance Char support:
The first commit adds String-fallback for Char columns to
df.convert()...andcharCol.convertTo<X>(). This means you can now do things likeConverting Char -> Int remains unchanged, it takes the char code instead of the value, similar to casting a char to int in java.
The second commit adds "treating chars as strings" behavior to the
df.convertTo<Schema> {}DSL. This makes the behavior mentioned in #998 possible again:This we could change to
charParser {}andparser {}separately if we wish so. It's still up for debate.The third commit introduces parsing of
Charcolumns, similar to String columns.This means you can now do:
and
Charcolumns will also be considered when callingDataFrame.parse().I still need to update the docs, but first I want to be sure there are not other places that could benefit from this Char-as-String treatment.