Skip to content

statistics documentation update #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2025
Merged

statistics documentation update #1165

merged 3 commits into from
May 1, 2025

Conversation

Jolanrensen
Copy link
Collaborator

@Jolanrensen Jolanrensen commented Apr 30, 2025

Helps #961

Needs follow-up from #1167

@Jolanrensen Jolanrensen added the documentation Improvements or additions to documentation (not KDocs) label Apr 30, 2025
@Jolanrensen Jolanrensen added this to the 1.0.0-Beta1 (0.16) milestone Apr 30, 2025
@Jolanrensen Jolanrensen marked this pull request as ready for review April 30, 2025 13:46
Copy link
Collaborator

@zaleslaw zaleslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you've added a table of type conversions, a little bit column with skipNaN option misleads there, but probably it's fine

@Jolanrensen
Copy link
Collaborator Author

@zaleslaw how do you mean "mislead"?

@zaleslaw
Copy link
Collaborator

zaleslaw commented May 1, 2025

Lead in the wrong direction/perception, it is mixed resulting type and Parameter info, probably better to write directly about nullability

@Jolanrensen Jolanrensen merged commit 3c98b9a into master May 1, 2025
6 of 7 checks passed
@Jolanrensen Jolanrensen deleted the statistics-docs branch May 1, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation (not KDocs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants