-
Notifications
You must be signed in to change notification settings - Fork 71
Generate fields for markers in REPL so compiler plugin can extract the schema #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -4,5 +4,9 @@ public interface DataFrameSchema { | |||
|
|||
public val columns: Map<String, ColumnSchema> | |||
|
|||
public fun compare(other: DataFrameSchema): CompareResult | |||
/** | |||
* By default generated markers for leafs aren't used as supertypes: @DataSchema(isOpen = false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we use the word "leaf" for DataFrames. Value/Frame columns are used for this purpose I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"strictlyEqualValueCols" maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe "nested schemas" is a better wording, idk. By leaf here i meant.
interface A {
val col: Int
val nested: B <== Leaf
val nestedFrame: List<B> <== Leaf
}
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you actually meant "node"? because the schema continues downwards in a different schema? (B
is a schema too right?) a "leaf" is normally a node with no children
Yes, then nested schema is better definitely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see here the gravitation of Graph Theory with presenting dataframe as a tree.
I am fine with both schema - oriented and graph theory oriented wording, but... have a guess that our users closer to the hierarchical schemas wording
without this change plugin cannot see schemas from previous cells, generated by REPL:
After this PR generated markers (DataFrame<T>) will have unified structure, so schema can be extracted from both REPL and plugin generated ones