fix: param settings FAB obstructs StoryContent #68
Conversation
|
I found that FAB obstruct preview content in bottom left corner. So I moved param settings button to the TopAppBar. Also |
modules/runtime-api/src/commonMain/kotlin/org/jetbrains/compose/storytale/Story.kt
Show resolved
Hide resolved
|
Thank you so much for all of your contributions 🙏 |
| exit = fadeOut(), | ||
| modifier = Modifier.align(Alignment.BottomEnd), | ||
| ) { | ||
| SmallFloatingActionButton( |
There was a problem hiding this comment.
This Floating Action Button was added here according to the re-design by our team's designer. It should've not been removed from here.
There was a problem hiding this comment.
Sorry to hear that. I'll make a revert PR later
There was a problem hiding this comment.
I understand that you didn't know about it.
I'd be glad to share the design files, but unfortunately they are in private Figma, and we can't share it.
I appreciate your contributions and improvements in the project 🙂
I'm currently working on a branch which I'm going to push soon (today). I already added a revert of this PR there. So you don't need to revert yourself.
In the future please consider:
- updating the versions of the dependencies in seprate PRs (gradle, agp, etc), unless they are absolutely related to the feature/fix you implement.
In this case the new gradle version affect the Compose project where we use Storytale. We can't update the gradle there yet. So for now we'll need to stick to an older gradle version here.
New screenshot:
