Skip to content

fix(contracts): point kitty specs at canonical protocol matrices - #159

Open
KooshaPari wants to merge 1 commit into
mainfrom
fix/protocol-contract-path-20260828
Open

fix(contracts): point kitty specs at canonical protocol matrices#159
KooshaPari wants to merge 1 commit into
mainfrom
fix/protocol-contract-path-20260828

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Aug 28, 2026

Copy link
Copy Markdown
Owner

User description

One-symlink repair: repoints root kitty-specs from the incomplete runtime test-contract directory to canonical tracked docs/specs, restoring the existing protocol-parity matrix path without copying or changing contract content. Audit evidence: the prior target lacked only protocol-parity-matrix.json, while the canonical docs tree contains both required matrix and envelope.


CodeAnt-AI Description

Restore the canonical protocol contract location

What Changed

  • Protocol contract lookups now use the tracked docs/specs directory instead of the incomplete runtime test-contract directory
  • Restores access to the existing protocol parity matrix and related contract files without changing their contents

Impact

✅ Reliable protocol contract discovery
✅ Restored protocol parity checks

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Copilot AI lite review requested due to automatic review settings August 28, 2026 08:18
@codeant-ai

codeant-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR dd42ef7 Aug 28, 2026 · 08:18 08:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codeant-ai

codeant-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Aug 28, 2026
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Compliance Check ✅

All constitution compliance checks passed!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd42ef7e1c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread kitty-specs
@@ -1 +1 @@
apps/runtime/tests/contracts No newline at end of file
docs/specs No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Point kitty-specs at assets matching the formal surface

When apps/runtime/tests/unit/protocol/protocol_parity_gate.test.ts runs its canonical-surface case, this target makes the gate read the stale matrix and schema under docs/specs: node tools/gates/protocol-parity.mjs reports missing recovery/secrets topics and unknown boundary entries, so the assertion at lines 35–38 fails. Retarget this symlink to synchronized assets, or update the docs/specs matrix and schema to match the current formal method/topic surface.

Useful? React with 👍 / 👎.

@github-actions

Copy link
Copy Markdown

⚠️ Self-merge is blocked due to missing requirements:

  • ❌ Not all quality gates have passed
  • ❌ PR does not have required review approval

Please ensure all checks pass before merging.

@github-actions

Copy link
Copy Markdown

Quality Gate Report

✅ Unit Tests: PASSED
✅ E2E Tests: PASSED
⏭️ Integration Tests: SKIPPED (no integration directory)
✅ FR Annotations: VALID

@kilo-code-bot

kilo-code-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Code Review Summary

Status: 1 Issue Found | Recommendation: Request Changes (blocks merge)

Overview

Severity Count
CRITICAL 1
WARNING 0
SUGGESTION 0
Issue Details (click to expand)

CRITICAL

File Line Issue
kitty-specs 1 Symlink now resolves to stale docs/specs matrix + contract schema; the protocol parity gate fails. Verified against the formal surface (specs/protocol/v1/topics.json, 50 topics): docs/specs/001-colab-agent-terminal-control-plane/contracts/protocol-parity-matrix.json is missing all 15 orphan.*, recovery.*, and secrets.* topics and instead adds 5 boundary.* topics that do not exist in the formal surface. The sibling orchestration-envelope.schema.json enum is also missing those 15 topics (the synchronized agileplus-specs/colab-agent-terminal-control-plane/contracts copy has all 15). tools/gates/protocol-parity.mjs therefore emits Formal topic 'X' missing from parity matrix, Parity matrix topic 'X' is not in formal surface, and Formal topics missing from contract schema enum errors, and the unit test apps/runtime/tests/unit/protocol/protocol_parity_gate.test.ts:35-38 ("passes against the complete canonical protocol surface") will fail. The PR description claims docs/specs is the canonical, complete target, but it is out of sync with the formal protocol surface. Fix by retargeting kitty-specs to the synchronized asset directory (e.g. agileplus-specs/colab-agent-terminal-control-plane) or by regenerating docs/specs/.../protocol-parity-matrix.json and orchestration-envelope.schema.json to match specs/protocol/v1/{topics,methods}.json. (Already flagged inline by another reviewer on this line; re-verified and confirmed.)
Files Reviewed (1 files)
  • kitty-specs

Fix these issues in Kilo Cloud


Reviewed by free · Input: 98.7K · Output: 12.2K · Cached: 389.6K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants