Skip to content

fix(ci): use managed environment for mypy hook - #152

Open
KooshaPari wants to merge 1 commit into
mainfrom
fix/pre-commit-mypy-language-20260828
Open

fix(ci): use managed environment for mypy hook#152
KooshaPari wants to merge 1 commit into
mainfrom
fix/pre-commit-mypy-language-20260828

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Aug 28, 2026

Copy link
Copy Markdown
Owner

User description

Summary

Removes the unsupported language: system override from the mirrors-mypy hook while retaining its pinned mirror revision, type-stub dependencies, arguments, and src/ entrypoint. This lets pre-commit create the managed Python hook environment required for additional_dependencies.

Validation

  • pre-commit validate-config /tmp/helioslab-pre-commit-config.yaml passed.
  • Existing warnings for mutable Rust nightly refs remain unchanged and are outside this PR.
  • Remote diff contains only the incompatible language: system deletion.

No hooks were disabled or weakened.


CodeAnt-AI Description

Restore managed pre-commit environments for Python type checks

What Changed

  • Python type checks now run in the managed environment provided by pre-commit
  • Type-checking dependencies remain available when the hook runs
  • Existing type-checking scope and options are unchanged

Impact

✅ Reliable pre-commit type checks
✅ Fewer hook setup failures

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Copilot AI lite review requested due to automatic review settings August 28, 2026 06:34
@codeant-ai

codeant-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR edb4b11 Aug 28, 2026 · 06:34 06:34

@codeant-ai

codeant-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

⚠️ Self-merge is blocked due to missing requirements:

  • ❌ Not all quality gates have passed
  • ❌ PR does not have required review approval

Please ensure all checks pass before merging.

@github-actions

Copy link
Copy Markdown

Compliance Check ✅

All constitution compliance checks passed!

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Quality Gate Report

✅ Unit Tests: PASSED
✅ E2E Tests: PASSED
⏭️ Integration Tests: SKIPPED (no integration directory)
✅ FR Annotations: VALID

@kilo-code-bot

kilo-code-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • .pre-commit-config.yaml — Removed language: system from the mirrors-mypy hook. This is a correct fix: language: system is incompatible with additional_dependencies because it tells pre-commit to use the system Python rather than creating a managed environment where the specified type stubs can be installed.

Reviewed by free · Input: 18.1K · Output: 6.6K · Cached: 70.8K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants