[fluent] refactor: Migrate to new FontIcon
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the code to use the new `FontIcon` component instead of relying on individual icons. - The `FontIcon` component is now used across components like `Expander`, `Scrollbar`, `ListItem`, `CheckBox`, `CalendarDatePicker`, `CommandBar`, `ColorPicker`, `NavigationView`, `LiteFilter`, `RatingControl`, `BreadcrumbBar`, `TopNav`, `SideNav`, `Button`, `TabView`, and `TextBoxButton`. - The `FontIcon` component is optimized for displaying font icons by using a dedicated font family. - The commit also introduces an enum class `FontIconPrimitive` that defines a set of standard icons for Fluent UI components. - Some components, such as `FontIconSolid8`, now use a custom size for better visual consistency. - The `ContextMenu` implementation for desktop is updated to leverage the `FontIcon` and `FontIconPrimitive` for icon display and keyboard shortcuts.
This commit applies the `LocalContentColor` and `LocalContentAlpha` to the `FontIcon` component, ensuring it inherits the appropriate color and alpha values from its parent context. This change improves the consistency and accessibility of icons within Fluent UI components.
This commit changes the default width of RatingControl from 20.dp to 16.dp to better align with the Fluent UI design guidelines.
This commit introduces two new icons, `BackIcon` and `NavigationIcon`, for use within the `NavigationView` component. - `BackIcon`: Represents a back button and provides a subtle scale animation on press. - `NavigationIcon`: Represents a navigation menu and provides a subtle scale animation on press. These icons are now used by default for the `BackButton` and `ExpandedButton` composables within `NavigationView`. They enhance the visual feedback and consistency of the navigation experience.
Sanlorng
force-pushed
the
component/font_icon_primitives
branch
from
ea66a6a
to
7c2a1d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the code to use the new
FontIconcomponent instead of relying on individual icons.FontIconcomponent is now used across components likeExpander,Scrollbar,ListItem,CheckBox,CalendarDatePicker,CommandBar,ColorPicker,NavigationView,LiteFilter,RatingControl,BreadcrumbBar,TopNav,SideNav,Button,TabView, andTextBoxButton.FontIconcomponent is optimized for displaying font icons by using a dedicated font family.FontIconPrimitivethat defines a set of standard icons for Fluent UI components.FontIconSolid8, now use a custom size for better visual consistency.ContextMenuimplementation for desktop is updated to leverage theFontIconandFontIconPrimitivefor icon display and keyboard shortcuts.