Skip to content

feat(installer): add portable setup option - #170

Open
tkkhq wants to merge 5 commits into
mainfrom
fix/installer-run-setup
Open

feat(installer): add portable setup option#170
tkkhq wants to merge 5 commits into
mainfrom
fix/installer-run-setup

Conversation

@tkkhq

@tkkhq tkkhq commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Tracking

Why

  • clients that install the CLI and immediately run volcano setup cannot rely on the installed directory being present in the current shell's PATH
  • the release installer requires Bash even though a POSIX shell can support its behavior
  • clients must duplicate the installer's path selection to run setup through the installed binary

Summary

  • make the release installer compatible with POSIX sh
  • add an installer --setup option that runs setup through the resolved installed binary path
  • warn before setup when volcano in PATH points to another binary
  • reject unknown installer options before downloading a release
  • test shell and package-manager selection for every OS and architecture published in GitHub Releases
  • document the portable install and combined setup commands

Verification

  • sh -n scripts/install-volcano.sh scripts/install-volcano.test.sh
  • sh scripts/install-volcano.test.sh
  • shellcheck -s sh scripts/install-volcano.sh scripts/install-volcano.test.sh
  • node --test scripts/npm/download.test.js
  • make check
  • confirmed the latest GitHub release publishes Linux AMD64/ARM64, macOS AMD64/ARM64, and Windows AMD64 binaries

@tkkhq
tkkhq requested a review from a team as a code owner August 24, 2026 10:47
Copilot AI balanced review requested due to automatic review settings August 24, 2026 10:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@tkkhq tkkhq changed the title feat(installer): add setup option feat(installer): add portable setup option Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants