Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[merge] feat/wasm-foreign-function #671

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

thibaultcha
Copy link
Member

@thibaultcha thibaultcha commented Jan 28, 2025

  • coverage error case
  • coverage on CI
  • docs

The trap message describing the lua_resolver being called in unsupported
context exceeds the current limit.
Making struct member names explict to distinguish them from the upcoming
Proxy-Wasm foreign call support.
@thibaultcha thibaultcha force-pushed the feat/wasm-foreign-function-merge branch from 8ca77e7 to 7ab5e3e Compare January 28, 2025 23:15
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 83.27402% with 47 lines in your changes missing coverage. Please review.

Project coverage is 90.71817%. Comparing base (004ae21) to head (cb37e23).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...rc/common/proxy_wasm/ngx_proxy_wasm_foreign_call.c 75.67568% 36 Missing ⚠️
src/common/proxy_wasm/ngx_proxy_wasm_host.c 87.50000% 3 Missing ⚠️
src/http/ngx_http_wasm_util.c 81.25000% 3 Missing ⚠️
src/http/proxy_wasm/ngx_http_proxy_wasm.c 84.21053% 3 Missing ⚠️
src/http/proxy_wasm/ngx_http_proxy_wasm_dispatch.c 93.93939% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #671         +/-   ##
===================================================
- Coverage   90.82100%   90.71817%   -0.10283%     
===================================================
  Files             53          54          +1     
  Lines          11352       11571        +219     
  Branches        1691        1711         +20     
===================================================
+ Hits           10310       10497        +187     
- Misses          1036        1068         +32     
  Partials           6           6                 
Files with missing lines Coverage Δ
src/common/proxy_wasm/ngx_proxy_wasm.c 92.79570% <100.00000%> (+0.08623%) ⬆️
src/common/proxy_wasm/ngx_proxy_wasm.h 92.30769% <ø> (ø)
src/common/proxy_wasm/ngx_proxy_wasm_maps.c 94.01042% <100.00000%> (ø)
src/common/proxy_wasm/ngx_proxy_wasm_util.c 94.25287% <100.00000%> (ø)
src/http/proxy_wasm/ngx_http_proxy_wasm_dispatch.c 91.76471% <93.93939%> (+0.33614%) ⬆️
src/common/proxy_wasm/ngx_proxy_wasm_host.c 93.61233% <87.50000%> (-0.18699%) ⬇️
src/http/ngx_http_wasm_util.c 86.98980% <81.25000%> (-0.24424%) ⬇️
src/http/proxy_wasm/ngx_http_proxy_wasm.c 92.99065% <84.21053%> (-0.88690%) ⬇️
...rc/common/proxy_wasm/ngx_proxy_wasm_foreign_call.c 75.67568% <75.67568%> (ø)

... and 2 files with indirect coverage changes

Flag Coverage Δ
unit ?
unit-ngx_1.21.6-wasmer-no_ipc-ssl-debug-no_hup-static 89.30334% <70.96774%> (?)
unit-ngx_1.27.3-v8-no_ipc-ssl-debug-no_hup-static 89.64469% <70.96774%> (?)
unit-ngx_1.27.3-wasmer-no_ipc-no_ssl-no_debug-no_hup-static 86.42742% <70.17544%> (?)
unit-ngx_1.27.3-wasmer-no_ipc-ssl-debug-no_hup-static 89.34256% <70.96774%> (?)
unit-ngx_1.27.3-wasmer-no_ipc-ssl-no_debug-no_hup-static 86.79015% <70.17544%> (?)
unit-ngx_1.27.3-wasmtime-ipc-no_ssl-debug-no_hup-static 88.92170% <70.96774%> (?)
unit-ngx_1.27.3-wasmtime-no_ipc-no_ssl-debug-no_hup-static-wasm32-unknown-unknown 88.33017% <70.96774%> (?)
unit-ngx_1.27.3-wasmtime-no_ipc-ssl-debug-hup-dynamic 88.37398% <70.96774%> (?)
unit-ngx_1.27.3-wasmtime-no_ipc-ssl-debug-hup-static 88.34963% <70.96774%> (?)
unit-openresty_1.27.1.1-wasmtime-no_ipc-ssl-debug-no_hup-dynamic 90.68403% <90.28340%> (?)
unit-openresty_1.27.1.1-wasmtime-no_ipc-ssl-debug-no_hup-static 90.64271% <90.28340%> (?)
valgrind ?
valgrind-ngx_1.27.3-v8---debug-no_hup-static 33.18855% <2.22222%> (?)
valgrind-ngx_1.27.3-wasmer---debug-hup-static 80.43789% <60.74074%> (?)
valgrind-ngx_1.27.3-wasmer---debug-no_hup-static 80.53691% <60.74074%> (?)
valgrind-ngx_1.27.3-wasmtime---debug-no_hup-static 33.52608% <2.22222%> (?)
valgrind-openresty_1.27.1.1-wasmer---debug-no_hup-static 61.52290% <24.63235%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@thibaultcha thibaultcha force-pushed the feat/wasm-foreign-function-merge branch 6 times, most recently from 43474a8 to 521b41b Compare January 29, 2025 20:11
@thibaultcha thibaultcha force-pushed the feat/wasm-foreign-function-merge branch 2 times, most recently from d434281 to fba5d30 Compare January 30, 2025 02:58
casimiro and others added 2 commits January 29, 2025 19:36
Also adds `resolve_lua` foreign function, which allows filter developers
to resolve names using the Lua DNS resolver.
@thibaultcha thibaultcha force-pushed the feat/wasm-foreign-function-merge branch from fba5d30 to cb37e23 Compare January 30, 2025 03:36
@thibaultcha thibaultcha merged commit ea1ec76 into main Jan 30, 2025
30 checks passed
@thibaultcha thibaultcha deleted the feat/wasm-foreign-function-merge branch January 30, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants