fix(proxy-wasm) pass hardcoded 0 as vm_configuration_size

[dev-null-undefined]

pass hardcoded 0 instead of misleading constant

fixes #654

[CLAassistant]

All committers have signed the CLA.

[thibaultcha]

We do support VM config as discussed in the issue so let's pass the correct value instead. Such a PR will also need test cases.

[dev-null-undefined]

We do support VM config as discussed in the issue so let's pass the correct value instead. Such a PR will also need test cases.

My bad I missread your original comment on the issue and though you do not support VM configuration :D

[thibaultcha]

Thanks for the update. To merge your PRs we will need you to sign our CLA as well as contribute the necessary regression tests when needed (this one needs it). For this test we will need to update the 001-on_root_phases.t suite: duplicating the TEST 1 with TEST 1 - on_vm_start without configuration and TEST 2 - on_vm_start with configuration. The second test needs to define a VM config in the module directive and assert the error log. It's very simple copy-pasting and many tests do this in the codebase already.

[thibaultcha]

When dealing with tests, have a look at the developer documentation at https://github.com/Kong/ngx_wasm_module/blob/main/docs/DEVELOPER.md and look for the Makefile targets, for example make test or make reindex. The developer documentation is very detailed and should cover everything.