[CI] fix(*) ensure fake requests filter chains are freed #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were observing linear memory growth when running requests in low-isolation modes. The root cause comes from the fact that small allocations had instance-long lifetimes (including, for example, the arrays for `args` and `rets` for each Wasm call, causing the observable linear growth when running wrk). Turns out that `ngx_pfree`, which was being used in the code to free `args` and `rets`, does not free small allocations. It only frees large allocations; small allocations are only freed when the pool itself is destroyed. The solution is to use a request-lived pool for `pwctx`, so we don't hoard small request-specific allocations over the lifetime of an instance. We also change the setup of the `pwexec` pool so that it uses the `pwctx` pool under all isolation modes, like it does for logs. Wasm isolation mode should pertain only to the Wasm-accessible store, not to the temporary C-side data structures, which we now free on each request.
Perform adjustment of arguments and return values in the stack for the common case of functions with fewer than 10 arguments and/or 10 returns.
Such as fake request passed to the FFI via the init_worker_by_lua fake request.
thibaultcha
force-pushed
the
fix/memory-pool-fakereq
branch
from
0d63b5f to
f7f9ca8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
===================================================
- Coverage 90.26802% 90.15260% -0.11543%
===================================================
Files 46 46
Lines 8395 8388 -7
===================================================
- Hits 7578 7562 -16
- Misses 817 826 +9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patch atop #420 for an underlying issue regarding fake requests "fake" filter chains.