tests(*) tests for client/upstream connection drop #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casimiro
force-pushed
the
test/connection-drop
branch
7 times, most recently
from
1cd83a4 to
5ec1d93
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
===================================================
+ Coverage 90.11905% 90.13095% +0.01189%
===================================================
Files 46 46
Lines 8400 8400
===================================================
+ Hits 7570 7571 +1
+ Misses 830 829 -1 |
casimiro
force-pushed
the
test/connection-drop
branch
9 times, most recently
from
51e24bf to
a1bcd2b
Compare
casimiro
changed the title
casimiro
changed the title
|
@casimiro Could you rebase this PR so we can go ahead with a smooth merge? Thanks! |
casimiro
force-pushed
the
test/connection-drop
branch
from
a1bcd2b to
0f0efb6
Compare
casimiro
added
pr/work-in-progress
casimiro
force-pushed
the
test/connection-drop
branch
from
fe66240 to
83c1325
Compare
casimiro
force-pushed
the
test/connection-drop
branch
from
83c1325 to
0ea004c
Compare
casimiro
force-pushed
the
test/connection-drop
branch
from
0ea004c to
0e814f1
Compare
|
@casimiro Just rebase and the Valgrind failures will go away. |
casimiro
force-pushed
the
test/connection-drop
branch
2 times, most recently
from
c556126 to
78b4b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a set of test cases that documents the behaviour of ngx_wasm_module on the events of connection drop both from client and upstream.
It also include fixes for bugs encountered during the investigation.