misc(proxy-wasm) improve filter chain errors clarity & consistency #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thibaultcha
commented
Sep 15, 2023
•
thibaultcha
commented
- Clarify error messages.
- Avoid producing an error log and a subsequent warning log, since it distracts from the initial error log.
- Carefully separate filter error loggers from filter chain errors (filter vs. host runloop).
- Remove a redundant test.
thibaultcha
force-pushed
the
misc/proxy-wasm-error-logs
branch
2 times, most recently
from
0150e79 to
c733e1b
Compare
thibaultcha
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
===================================================
+ Coverage 90.25116% 90.27993% +0.02876%
===================================================
Files 46 46
Lines 8401 8395 -6
===================================================
- Hits 7582 7579 -3
+ Misses 819 816 -3
|
thibaultcha
force-pushed
the
misc/proxy-wasm-error-logs
branch
2 times, most recently
from
02a689d to
51a582f
Compare
* Clarify error messages * Avoid producing an error log and a subsequent warning log, since it distracts from the initial error log. * Carefully separate filter error loggers from filter chain errors (filter vs. host runloop).
thibaultcha
force-pushed
the
misc/proxy-wasm-error-logs
branch
from
51a582f to
9e13e2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.