Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci) bump and sync CC version among Dockerfiles and CI workflows #409

Merged
merged 3 commits into from
Sep 13, 2023
Merged

chore(ci) bump and sync CC version among Dockerfiles and CI workflows #409

merged 3 commits into from
Sep 13, 2023

Conversation

casimiro
Copy link
Contributor

@casimiro casimiro commented Sep 7, 2023

Dockerfiles and CI workflow use the latest version available in the runner OS.

Older versions of gcc and clang are tested in CI Large.

@casimiro casimiro added the pr/work-in-progress PR: Work in progress label Sep 7, 2023
@casimiro casimiro force-pushed the chore/ci-sync-cc-version branch 6 times, most recently from 52ee467 to 128bc62 Compare September 11, 2023 14:50
@coveralls
Copy link

coveralls commented Sep 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6172826617

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 91.088%
Totals Coverage Status
Change from base Build 6164439744: 0.005%
Covered Lines: 7584
Relevant Lines: 8326
💛 - Coveralls

@casimiro casimiro force-pushed the chore/ci-sync-cc-version branch from 128bc62 to bc6b5ce Compare September 11, 2023 16:25
@casimiro casimiro force-pushed the chore/ci-sync-cc-version branch 2 times, most recently from a68f746 to e2f287c Compare September 11, 2023 19:10
@casimiro casimiro removed the pr/work-in-progress PR: Work in progress label Sep 11, 2023
@casimiro casimiro force-pushed the chore/ci-sync-cc-version branch from e2f287c to 863a000 Compare September 11, 2023 22:31
thibaultcha
thibaultcha reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@thibaultcha thibaultcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Let's make the fix a part of the changelog as its own commit too and we'll be set!

src/wasm/ngx_wasm_ops.c Show resolved Hide resolved
@casimiro casimiro force-pushed the chore/ci-sync-cc-version branch from 863a000 to 24bf8d7 Compare September 12, 2023 10:08
@casimiro casimiro force-pushed the chore/ci-sync-cc-version branch 3 times, most recently from 70244fd to 5498569 Compare September 13, 2023 12:28
@casimiro
chore(act) add missing rust targets to docker image
e78e9a6 
Since commit 70552dd,
steps for installing rust targets in CI workflows are skipped
when executed by act.

This commit introduces Rustup commands in Dockerfile.ubuntu-22.04
which installs the missing targets.
@casimiro
chore(ci) bump and sync CC version among Dockerfiles and CI workflows
95fd249 
Dockerfiles and CI workflow use the latest version available in the
runner OS.

Older versions of gcc and clang are tested in CI Large.
@casimiro
fix(*) address minor issues reported by newer clang-analyzer
a5e7f7e
@casimiro casimiro force-pushed the chore/ci-sync-cc-version branch from 5498569 to a5e7f7e Compare September 13, 2023 13:00
@thibaultcha thibaultcha merged commit a2f1a6f into main Sep 13, 2023
30 checks passed
@thibaultcha thibaultcha deleted the chore/ci-sync-cc-version branch September 13, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaultcha thibaultcha thibaultcha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@casimiro @coveralls @thibaultcha