fix(proxy-wasm) improve instance recycling robustness #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thibaultcha
commented
Sep 5, 2023
•
thibaultcha
commented
- Allow for recycling the root instance (not managed by isolation modes)
- Allow for smoother recycling of http instances (including when the root instance has trapped)
- Also recycle trapped instances in the busy queue
- Less verbose context creation of fresh and/or recycled instances starting in atypical steps (e.g. on_response_headers).
thibaultcha
force-pushed
the
fix/proxy-wasm-instance-recycling
branch
5 times, most recently
from
4eef75a to
73e76db
Compare
* Allow for recycling the root instance (not managed by isolation modes) * Allow for smoother recycling of http instances (including when the root instance has trapped) * Also recycle trapped instances in the busy queue * Less verbose context creation of fresh and/or recycled instances starting in atypical steps (e.g. on_response_headers).
Prior, the sweeping queue was only destroyed at worker shutdown, but it was intended for it to be sweeped sooner. This gets away with the sweeping queue and frees instances on the sport instead.
thibaultcha
force-pushed
the
fix/proxy-wasm-instance-recycling
branch
from
125ee47 to
34ee461
Compare
|
This turned into what is currently a pretty heavy refactor of the proxy-wasm instance/context relationship, which was still unfinished (had lots of leftover code from before |
|
Moved to #422. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.