fix(ci): fix pinned enterprise tag

[pmalek]

What this PR does / why we need it:

This PR unpins the enterprise tag that we set in integration tests. This way the nightly tests and locally run tests will respect TEST_KONG_IMAGE and TEST_KONG_TAG through

kubernetes-ingress-controller/test/internal/testenv/testenv.go

Lines 24 to 32 in 3ce7c14

	// KongImage is the Kong image to use in lieu of the default.
	func KongImage() string {
	return os.Getenv("TEST_KONG_IMAGE")
	}
	// KongTag is the Kong image tag to use in tests.
	func KongTag() string {
	return os.Getenv("TEST_KONG_TAG")
	}

and

kubernetes-ingress-controller/test/internal/helpers/ktf.go

Lines 32 to 37 in 3ce7c14

	if image, tag := testenv.KongImage(), testenv.KongTag(); image != "" {
	if tag == "" {
	return nil, nil, fmt.Errorf("TEST_KONG_IMAGE requires TEST_KONG_TAG")
	}
	kongbuilder = kongbuilder.WithProxyImage(image, tag)
	}

Special notes for your reviewer:

This is just unblocking and kicking the can down the road. We need to figure out an approach for this.

Related: Kong/kubernetes-testing-framework#542

• If we set a default in ktf then we'd need to bump that every GW release, release ktf and then use that version in KIC
• If we set a default in KIC (in CI just like this PR does it?) then we need to maintain it here
• If we add a mechanism in KIC that always returns the latest GW tag:
  • This will get this data from Github so without tokens we have to take into account rate limiting
  • Without changing code and/or ktf version a version that we test against might change, hence surprises might happen.
• Any other ideas?

Since that essentially sets a value in chart's values we're basically overriding what's set there by default. So we're sort of having a special case for enterprise whereas CE has it's tag set in respective chart's version values.

[codecov]

Codecov Report

Base: 74.0% // Head: 73.9% // Decreases project coverage by -0.1% ⚠️

Coverage data is based on head (71557d2) compared to base (1084eb6).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #3508     +/-   ##
=======================================
- Coverage   74.0%   73.9%   -0.1%     
=======================================
  Files        118     118             
  Lines      13886   13886             
=======================================
- Hits       10277   10264     -13     
- Misses      2952    2961      +9     
- Partials     657     661      +4     

Impacted Files	Coverage Δ
...nternal/controllers/gateway/udproute_controller.go	71.6% <0.0%> (-2.2%)	⬇️
internal/dataplane/kongstate/service.go	66.0% <0.0%> (-1.3%)	⬇️
internal/dataplane/parser/parser.go	90.7% <0.0%> (-0.9%)	⬇️
internal/dataplane/parser/backendref.go	100.0% <0.0%> (ø)
internal/dataplane/parser/wrappers_refchecker.go	64.4% <0.0%> (ø)
...ternal/controllers/gateway/httproute_controller.go	69.7% <0.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[czeslavo]

Since that essentially sets a value in chart's values we're basically overriding what's set there by default. So we're sort of having a special case for enterprise whereas CE has it's tag set in respective chart's version values.

This is kinda by design as the helm chart doesn't really have a default for EE proxy image (well, it has a comment).

IMO the best would be to have that handled on the chart level (as you noticed it is handled for CE). Maybe we should add something like image.edition that would accept {community, enterprise} and pin defaults to them to be used when this is specified?

[czeslavo]

Approving as a quick solution for unblocking

[pmalek]

IMO the best would be to have that handled on the chart level (as you noticed it is handled for CE). Maybe we should add something like image.edition that would accept {community, enterprise} and pin defaults to them to be used when this is specified?

That would be easier for us to customize perhaps but a breaking change for the end users.

Imagine upgrading from CE to EE and having to move the image and tag you specified to CE and switch that toggle you mentioned.