Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve caching for KTableData #2545

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: improve caching for KTableData #2545

wants to merge 3 commits into from

Conversation

Justineo
Copy link
Contributor

Summary

  • Update to swrv beta (with isLoading support).
  • Refactored <KTableData>
    • Simplify fetcher state calculation
    • Add fetcher params to SWRV key

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit f16a100
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/6772361b7a68590008ec5e21
😎 Deploy Preview https://deploy-preview-2545--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit f16a100
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/6772361b96dc7b0008ec7f61
😎 Deploy Preview https://deploy-preview-2545--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kongponents-bot
Copy link
Collaborator

Preview package from this PR in consuming application

In consuming application project install preview version of kongponents generated by this PR:

@kong/kongponents@pr-2545

Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove unused SwrvState import in KTableData.vue line 175

Comment on lines +11 to +13
<KButton @click="deleteZach(false)">
Delete Zach (no revalidate)
</KButton>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deletion with no revalidate only takes effect after pagination, and a subsequent revalidation.

  1. Click button
  2. Nothing happens in UI
  3. Paginate to second page
  4. Paginate back to first page
  5. Zach is initially in the list
  6. List revalidates, and then Zach is removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants