-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve caching for KTableData #2545
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
88c5399
to
f16a100
Compare
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove unused SwrvState
import in KTableData.vue
line 175
<KButton @click="deleteZach(false)"> | ||
Delete Zach (no revalidate) | ||
</KButton> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deletion with no revalidate only takes effect after pagination, and a subsequent revalidation.
- Click button
- Nothing happens in UI
- Paginate to second page
- Paginate back to first page
- Zach is initially in the list
- List revalidates, and then Zach is removed
Summary
swrv
beta (withisLoading
support).<KTableData>