tests(clustering): dp status ready when use RPC Sync #14035
Conversation
github-actions
bot
added
the
cherry-pick kong-ee
lhanjian
force-pushed
the
test/status_spec_ics
branch
from
e425e94 to
7794529
Compare
lhanjian
changed the title
lhanjian
force-pushed
the
test/status_spec_ics
branch
from
2b813f0 to
94557b4
Compare
chronolaw
changed the title
|
We should remove |
| @@ -106,64 +103,59 @@ for _, strategy in helpers.each_strategy() do | |||
| end, 10) | |||
| end) | |||
|
|
|||
| -- now dp receive config from cp, so dp should be ready | |||
|
|
|||
| skip_rpc_sync("should return 200 on data plane after configuring", function() | |||
There was a problem hiding this comment.
I think that you misunderstand my words, we still need this case for rpc_sync = off but not use skip_rpc_sync, it should be a normal it()
There was a problem hiding this comment.
It should also support {"off", "off"}
There was a problem hiding this comment.
note that "off" "off" has been supported by original test case, see Line 107,
I think we should write a completely new on on case to test incremental sync mode, like
if off off
-- using original cases
end
if on on then
-- write new cases in this pr
describe / it ()
....
end
end
So the new case does not need to support on
There was a problem hiding this comment.
because the original case (off off) will restart CP, if we implement new case in this scenario, current CP/DP incremental sync is hard to make the case stable, it is easy to get flakiness.
Why?
because restarting CP will cause DP connecting CP and introduce some delay, and currently in incremental sync feature, we could not have a good way to ensure the established connection between CP and DP. I think if we want to test CP/DP restart , we could file a new kag to track.
lhanjian
force-pushed
the
test/status_spec_ics
branch
from
4ee5355 to
a028af9
Compare
| @@ -106,64 +103,59 @@ for _, strategy in helpers.each_strategy() do | |||
| end, 10) | |||
| end) | |||
|
|
|||
| -- now dp receive config from cp, so dp should be ready | |||
|
|
|||
| skip_rpc_sync("should return 200 on data plane after configuring", function() | |||
There was a problem hiding this comment.
It should also support {"off", "off"}
lhanjian
force-pushed
the
test/status_spec_ics
branch
from
8ac99c7 to
26dc2a4
Compare
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5994