Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(lmdb): remove the key with global workspace id * #14028

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

perf(lmdb): remove the key with global workspace id * #14028

wants to merge 15 commits into from
+77 −44

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Dec 17, 2024 •
edited
Loading

Summary

  1. redesign the key format for LMDB
  2. remove the key with * workspace
  3. search all the workspaces if upper user calls select() API without providing the specific workspace id

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-5704

@github-actions github-actions bot added core/db cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 17, 2024
@chobits
Copy link
Contributor Author

chobits commented Dec 17, 2024

See design doc: https://docs.google.com/document/d/11UDFlk7h5Wy30lp3RnNMLmgD_VT-GOzwboqxssoCcLI/edit?usp=sharing

@chobits chobits force-pushed the fix/lmdb_reduce_global_query branch from 8c7372b to 372553f Compare December 17, 2024 08:48
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 17, 2024
chronolaw
chronolaw reviewed Dec 18, 2024
View reviewed changes
kong/db/strategies/off/init.lua Show resolved Hide resolved
kong/db/strategies/off/init.lua Outdated Show resolved Hide resolved
@chobits chobits force-pushed the fix/lmdb_reduce_global_query branch from 193f5b4 to 2e9a2ff Compare December 18, 2024 15:10
@chobits
Copy link
Contributor Author

chobits commented Dec 19, 2024 •
edited
Loading

cherry-pick will fail, so i file one cherry-pick pr: https://github.com/Kong/kong-ee/pull/10965 （cases passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@chronolaw chronolaw chronolaw approved these changes

Assignees

@chobits chobits

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db size/L skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chobits @chronolaw @StarlightIbuki