fix(pdk): set_target sets balancer_data.ip when host is an ip #14004
+89
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/pdk
cherry-pick kong-ee
gszr
requested changes
Dec 16, 2024
| @@ -103,6 +104,12 @@ local function new() | |||
| ngx.var.upstream_host = host | |||
|
|
|||
| local ctx = ngx.ctx | |||
| local hostname_typ = hostname_type(host) | |||
There was a problem hiding this comment.
We should document the new behavior in the ldoc above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To proxy to the expected address, the balancer phase needs the IP address to be set in
ngx.ctx.balancer_data.ip. This change setsngx.ctx.balancer_data.ipif thehostargument used when callingset_targetcontains an IPv4 or IPv6 address.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Close #13775
KAG-5628