Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(cmd): clean and prepare the prefix directory for each test case #13878

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flrgh
Copy link
Contributor

@flrgh flrgh commented Nov 15, 2024

This ensures that the prefix directory is reset to a known state after other test runs (and in between individual test cases), fixing a flakiness issue we've been seeing in CI:

FAIL spec/02-integration/02-cmd/06-restart_spec.lua:23: kong restart restarts if not running
spec/02-integration/02-cmd/06-restart_spec.lua:26: Error: in-memory storage can not be used when role = "control_plane"

Run with --v (verbose) or --vv (debug) for more details

See: https://github.com/Kong/kong/actions/runs/11863132780/job/33064282843#step:21:854

This ensures that the prefix directory is reset to a known state after
other test runs (and in between individual test cases), fixing a
flakiness issue we've been seeing in CI:

> FAIL spec/02-integration/02-cmd/06-restart_spec.lua:23: kong restart restarts if not running
> spec/02-integration/02-cmd/06-restart_spec.lua:26: Error: in-memory storage can not be used when role = "control_plane"
>
>  Run with --v (verbose) or --vv (debug) for more details
@flrgh flrgh added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/3.8.x cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant