Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sync): full sync not working if dedicated disabled #13857

Merged
merged 4 commits into from
Nov 13, 2024
Merged

fix(sync): full sync not working if dedicated disabled #13857

merged 4 commits into from
Nov 13, 2024

Conversation

StarlightIbuki
Copy link
Contributor

Summary

Clustering initialization needs to be handled when dedicated worker is off

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-5807

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Nov 11, 2024
chobits
chobits reviewed Nov 11, 2024
View reviewed changes
kong/init.lua Outdated Show resolved Hide resolved
@chobits
Copy link
Contributor

chobits commented Nov 12, 2024

I have tested this pr using its generated image tag: kong/kong-gateway-dev:da7be384030787b1477a8972d0a88d7abb236534-ubuntu, with this fix, the DP could work as expected.

@chronolaw
Copy link
Contributor

The related test cases will be added in KAG-5811.

StarlightIbuki
StarlightIbuki commented Nov 13, 2024
View reviewed changes
kong/init.lua Outdated Show resolved Hide resolved
@ADD-SP ADD-SP merged commit f494c53 into master Nov 13, 2024
26 checks passed
@ADD-SP ADD-SP deleted the fix/dedicate-full-sync branch November 13, 2024 06:28
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@chronolaw chronolaw mentioned this pull request Nov 13, 2024
Merged
3 tasks
ADD-SP pushed a commit that referenced this pull request Nov 15, 2024
@chronolaw
tests(clustering): sync v1 should work with or without privileged age…
da1100d 
…nt (#13866)

Refactored some code in #13857

KAG-5807, KAG-5811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

@chobits chobits chobits approved these changes

Assignees

@StarlightIbuki StarlightIbuki

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StarlightIbuki @chobits @chronolaw @team-gateway-bot @ADD-SP