Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(clustering/rpc): add test cases for inc sync #13853

Merged
merged 9 commits into from
Nov 12, 2024
Merged

tests(clustering/rpc): add test cases for inc sync #13853

merged 9 commits into from
Nov 12, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 9, 2024 •
edited
Loading

Summary

KAG-5729
KAG-5736
KAG-5755
KAG-5770
KAG-5757

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Nov 9, 2024
@chronolaw chronolaw marked this pull request as ready for review November 9, 2024 04:26
@chronolaw chronolaw changed the title tests(clustering/prc): add test cases for inc sync tests(clustering/rpc): add test cases for inc sync Nov 9, 2024
chobits
chobits approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@chobits chobits left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good starting point for an incremental test case.

StarlightIbuki
StarlightIbuki approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@StarlightIbuki StarlightIbuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I believe those are already covered by other tests, but it looks fine

@ADD-SP ADD-SP merged commit af7c174 into master Nov 12, 2024
25 checks passed
@ADD-SP ADD-SP deleted the tests/cases_for_inc_sync branch November 12, 2024 01:47
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@chobits chobits chobits approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/L skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @team-gateway-bot @chobits @StarlightIbuki @ADD-SP