fix(db): targets:upsert to properly handle errors #13584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary `kong.db.targets:upsert` was not handling errors with `kong.db.targets:each_for_upstream` correctly. This fixes it. Signed-off-by: Aapo Talvensaari <[email protected]>
github-actions
bot
added
core/db
schema-change-noteworthy
cherry-pick kong-ee
|
Should we add a change log entry? |
@chronolaw please suggest what to write there? In general I don't feel this of any value to our users (the changelog describing this - nobody has probably ever hit to this). |
nowNick
approved these changes
Sep 17, 2024
samugi
approved these changes
Sep 17, 2024
|
Successfully created cherry-pick PR for |
curiositycasualty
pushed a commit
that referenced
this pull request
Oct 15, 2024
### Summary `kong.db.targets:upsert` was not handling errors with `kong.db.targets:each_for_upstream` correctly. This fixes it. Signed-off-by: Aapo Talvensaari <[email protected]> (cherry picked from commit 71e7cb6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
kong.db.targets:upsertwas not handling errors withkong.db.targets:each_for_upstreamcorrectly. This fixes it.