This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
feat: Include tags in metrics labels #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
carnei-ro
force-pushed
the
feat/include-tags-in-metrics-labels
branch
from
08bc80e
to
e4db818
Compare
carnei-ro
force-pushed
the
feat/include-tags-in-metrics-labels
branch
from
e4db818
to
d2c4a41
Compare
|
need help with the flaky tests :) |
|
Hi @carnei-ro, thanks for this PR. We are in the process of moving some external plugins into the Kong main repository. We have just merged this one into Kong. Issues were also moved. We have created a card to review this PR; once we do, we will cherry-pick changes here into Kong. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/Kong/kong-plugin-prometheus/issues/126