Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec renderer #8036

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Spec renderer #8036

wants to merge 7 commits into from

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Oct 2, 2024

Motivation: use internal spec renderer, over swagger-ui-dist
Aim: drop-in replacement
Todo:

  • add and use @kong/spec-renderer
  • remove swagger-ui-dist
  • point at spec-renderer stable build
  • scroll overflow
  • color theming decision, either dark/light or take something similar to our css variable palette - using light
  • fix menu button appears incorrectly at bottom (could be opted out of with a prop)
  • fix Warning: You are calling ReactDOMClient.createRoot() on a container that has already been passed to createRoot() before. Instead, call root.render() on the existing root instead if you want to update it. appearing on each HMR
  • fix browser tab being opened on each HMR
  • fix e2e tests

Future work:

  • use bundler type module resolution in insomnia

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jackkav
❌ ValeryG
You have signed the CLA already but the status is still pending? Let us recheck it.

@jackkav
Copy link
Contributor Author

jackkav commented Oct 3, 2024

current state

image

@jackkav jackkav mentioned this pull request Oct 3, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants