Skip to content

Implement kong.log.set_serialize_value() #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Implement kong.log.set_serialize_value() #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
247b101
set string, num, bool values
Sep 15, 2024
ba49244
add bool test
Sep 16, 2024
a09d524
rm commented test
Sep 16, 2024
76875a4
restore previous format
Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions log/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package log

import (
"github.com/Kong/go-pdk/bridge"
"github.com/Kong/go-pdk/server/kong_plugin_protocol"
"google.golang.org/protobuf/types/known/structpb"
)

Expand Down Expand Up @@ -51,21 +52,29 @@ func (r Log) Debug(args ...interface{}) error {
}

// var (
// modeSet = map[string]string{ "mode": "set" }
// modeAdd = map[string]string{ "mode": "add" }
// modeReplace = map[string]string{ "mode": "replace" }
// modeSet = map[string]string{"mode": "set"}
// modeAdd = map[string]string{"mode": "add"}
// modeReplace = map[string]string{"mode": "replace"}
// )
//
// func (r Log) SetSerializeValue(key string, v interface{}) error {
// _, err := r.Ask(`kong.log.set_serialize_value`, key, v, modeSet)
// return err
// }
//

func (r Log) SetSerializeValue(key string, v interface{}) error {
value, err := structpb.NewValue(v)
if err != nil {
return err
}
arg := kong_plugin_protocol.KV{
K: key,
V: value,
}
err = r.Ask(`kong.log.set_serialize_value`, &arg, nil)
return err
}

// func (r Log) SetSerializeValueAdd(key string, v interface{}) error {
// _, err := r.Ask(`kong.log.set_serialize_value`, key, v, modeAdd)
// return err
// }
//

// func (r Log) SetSerializeValueReplace(key string, v interface{}) error {
// _, err := r.Ask(`kong.log.set_serialize_value`, key, v, modeReplace)
// return err
Expand Down
13 changes: 13 additions & 0 deletions log/log_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (

"github.com/Kong/go-pdk/bridge"
"github.com/Kong/go-pdk/bridge/bridgetest"
"github.com/Kong/go-pdk/server/kong_plugin_protocol"
"github.com/stretchr/testify/assert"
"google.golang.org/protobuf/types/known/structpb"
)
Expand Down Expand Up @@ -45,3 +46,15 @@ func TestSerialize(t *testing.T) {
assert.NoError(t, err)
assert.Equal(t, "{data...}", ret)
}

func TestSetSerializeValue(t *testing.T) {
log := mockLog(t, []bridgetest.MockStep{
{"kong.log.set_serialize_value", &kong_plugin_protocol.KV{K: "key", V: structpb.NewStringValue("value")}, nil},
{"kong.log.set_serialize_value", &kong_plugin_protocol.KV{K: "key", V: structpb.NewNumberValue(1)}, nil},
{"kong.log.set_serialize_value", &kong_plugin_protocol.KV{K: "key", V: structpb.NewBoolValue(true)}, nil},
})

assert.NoError(t, log.SetSerializeValue("key", "value"))
assert.NoError(t, log.SetSerializeValue("key", 1))
assert.NoError(t, log.SetSerializeValue("key", true))
}