-
Notifications
You must be signed in to change notification settings - Fork 133
feat: add konnect-control-plane-id flag #1686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e55e953 to
0a41e59
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1686 +/- ##
==========================================
- Coverage 28.19% 28.03% -0.16%
==========================================
Files 67 67
Lines 6949 6988 +39
==========================================
Hits 1959 1959
- Misses 4848 4887 +39
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0a41e59 to
bffe898
Compare
|
@Prashansa-K can you please take a look? |
cca6aaf to
278bde8
Compare
|
Also, some tests wherever relevant would be great! |
could you share the full command line used? this works for me $ ./deck gateway validate --konnect-addr https://us.api.konghq.tech --konnect-token $KONNECT_TOKEN_DEV test.json
$ cat test.json
{ "_format_version": "3.0"
, "_konnect": {"control_plane_id": "c4fe2fd4-c3e1-494e-b1ea-40a73415c456"}
} |
ea251e2 to
2a2d065
Compare
Introduce the --konnect-control-plane-id flag, which is mutually exclusive with the --konnect-control-plane-name flag. While names are more user-friendly, IDs are better suited for automation scripts due to their simplicity (no spaces, special characters, or sensitive names). This flag is intended for internal use and is therefore hidden.
Remove "warning:" as it is preceded by "Error:"
2a2d065 to
becd8f1
Compare
Introduce the --konnect-control-plane-id flag, which is mutually exclusive with the --konnect-control-plane-name flag. While names are more user-friendly, IDs are better suited for automation scripts due to their simplicity (no spaces, special characters, or sensitive names). This flag is intended for internal use and is therefore hidden.
requires Kong/go-database-reconciler#303