Skip to content

Conversation

@asartori86
Copy link
Contributor

Introduce the --konnect-control-plane-id flag, which is mutually exclusive with the --konnect-control-plane-name flag. While names are more user-friendly, IDs are better suited for automation scripts due to their simplicity (no spaces, special characters, or sensitive names). This flag is intended for internal use and is therefore hidden.

requires Kong/go-database-reconciler#303

@asartori86 asartori86 force-pushed the feat/konnect-control-plane-id-flag branch from e55e953 to 0a41e59 Compare July 3, 2025 07:05
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.

Project coverage is 28.03%. Comparing base (e835014) to head (becd8f1).

Files with missing lines Patch % Lines
cmd/common_konnect.go 0.00% 26 Missing ⚠️
cmd/common.go 0.00% 18 Missing ⚠️
cmd/root.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
- Coverage   28.19%   28.03%   -0.16%     
==========================================
  Files          67       67              
  Lines        6949     6988      +39     
==========================================
  Hits         1959     1959              
- Misses       4848     4887      +39     
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asartori86 asartori86 force-pushed the feat/konnect-control-plane-id-flag branch from 0a41e59 to bffe898 Compare July 3, 2025 07:16
@GGabriele GGabriele requested a review from Prashansa-K July 3, 2025 07:40
@GGabriele
Copy link
Collaborator

@Prashansa-K can you please take a look?

@harshadixit12 harshadixit12 self-requested a review July 9, 2025 10:26
@asartori86 asartori86 force-pushed the feat/konnect-control-plane-id-flag branch 2 times, most recently from cca6aaf to 278bde8 Compare July 9, 2025 13:54
@harshadixit12
Copy link
Contributor

harshadixit12 commented Jul 10, 2025

gateway_validate command seems to fail when id is given

Error: [konnect] section not specified - ensure details are set via cli flags

Also, some tests wherever relevant would be great!

@asartori86
Copy link
Contributor Author

gateway_validate command seems to fail when id is given

Error: [konnect] section not specified - ensure details are set via cli flags

Also, some tests wherever relevant would be great!

could you share the full command line used?

this works for me

$ ./deck gateway validate --konnect-addr https://us.api.konghq.tech --konnect-token $KONNECT_TOKEN_DEV  test.json 

$ cat test.json
{ "_format_version": "3.0"
, "_konnect": {"control_plane_id": "c4fe2fd4-c3e1-494e-b1ea-40a73415c456"}
}

@asartori86 asartori86 force-pushed the feat/konnect-control-plane-id-flag branch 5 times, most recently from ea251e2 to 2a2d065 Compare July 11, 2025 15:19
Introduce the --konnect-control-plane-id flag, which is mutually
exclusive with the --konnect-control-plane-name flag. While names are
more user-friendly, IDs are better suited for automation scripts due to
their simplicity (no spaces, special characters, or sensitive names).
This flag is intended for internal use and is therefore hidden.
Remove "warning:" as it is preceded by "Error:"
@asartori86 asartori86 force-pushed the feat/konnect-control-plane-id-flag branch from 2a2d065 to becd8f1 Compare July 11, 2025 15:33
@asartori86 asartori86 requested a review from harshadixit12 July 24, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants